[DPE-2991] Install + Start hook #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiaAltieri
commented
Nov 21, 2023
| @@ -0,0 +1,37 @@ | |||
| """Configuration for MongoDB Charm.""" | |||
There was a problem hiding this comment.
copied from MongoDB-operator and then removed some functions
MiaAltieri
commented
Nov 21, 2023
| @@ -0,0 +1,46 @@ | |||
| #!/usr/bin/env python3 | |||
There was a problem hiding this comment.
copied from MongoDB-operator
MiaAltieri
commented
Nov 21, 2023
src/machine_helpers.py
Outdated
| @@ -0,0 +1,32 @@ | |||
| """Machine Charm specific functions for operating MongoDB.""" | |||
There was a problem hiding this comment.
copied from mongodb-operator and removed functions
delgod
requested changes
Nov 22, 2023
MiaAltieri
force-pushed
the
install-hook
branch
from
d2428c4 to
ec0abec
Compare
MiaAltieri
force-pushed
the
install-hook
branch
from
2cbd547 to
04d0ac8
Compare
MiaAltieri
force-pushed
the
install-hook
branch
from
04d0ac8 to
56b7e43
Compare
dmitry-ratushnyy
approved these changes
Nov 27, 2023
delgod
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Files to review
lots of code was copied over I would suggest sticking with these files:
metadata.yamlsrc/charm.pytests/integration/test_charm.pytests/unit/test_charm.pyFuture Work