Implement tooling best practices #7
Conversation
.github/workflows/ci.yaml
Outdated
|
|
||
| build: | ||
| name: Build charms | ||
| # todo: update version |
There was a problem hiding this comment.
[already done]](
mongos-operator/.github/workflows/ci.yaml
Line 49 in 17ddef3
charmcraft.yaml
Outdated
| @@ -12,6 +12,7 @@ bases: | |||
|
|
|||
| parts: | |||
| charm: | |||
| # todo: remove binary packages | |||
There was a problem hiding this comment.
noob question, why do these need to be removed? last I checked charm wouldn't pack without these
There was a problem hiding this comment.
I think we're supposed to build python packages from source when possible
using something like this: https://github.com/canonical/mysql-operator/blob/f757f4e5e0c0719e8577adac2851274dee8da8a1/charmcraft.yaml#L24-L29
downside is that builds take a lot longer
tox.ini
Outdated
|
|
||
| poetry install --only fmt | ||
| poetry lock --no-update | ||
| # TODO: remove black? |
There was a problem hiding this comment.
noob question, why remove black
There was a problem hiding this comment.
I believe ruff replaces it
carlcsaposs-canonical
force-pushed
the
tooling-best-practices
branch
from
d890faa to
3b03581
Compare
carlcsaposs-canonical
force-pushed
the
tooling-best-practices
branch
from
3b03581 to
d9a8476
Compare
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
| tenacity = "^8.1.0" | ||
| pymongo = "^4.3.3" | ||
| ops = "^2.4.1" |
There was a problem hiding this comment.
@MiaAltieri FYI this might cause a headache in the future—your integration tests probably shouldn't depend on ops (but it looks like they import code which imports ops)
https://warthogs.atlassian.net/browse/DPE-3060