Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use POCO instead of QNetworkAccessManager to download urls #3708

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

levkropp
Copy link
Contributor

multipass find works, which means the new implementation can already successfully get data from https urls. I had to build with cmake ../ -DMULTIPASS_ENABLE_TESTS=off and packaging a snap without gui.

Immediate things to work on:

  • SSL Certificate Verification is disabled for testing purposes (VERIFY_NONE)

    Poco::Net::Context::Ptr context = new Poco::Net::Context(
    Poco::Net::Context::CLIENT_USE,
    "",
    "",
    "",
    Poco::Net::Context::VERIFY_NONE,
    9,
    false,
    "ALL");

    https://docs.pocoproject.org/current/Poco.Net.Context.html

  • Tests need to be remade for POCO

  • multipass start and (in my experience) multipassd crashes instantly, no logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant