[gui] Open and close terminal tabs keyboard shortcuts

[sharder996]

Tried playing around with the GUI and adding a change I'd personally like to see. Behaviour still isn't exactly how I'd like it. @andrei-toterman, a little help if you have time :)

Tabs open and close as expected with Ctrl+t/Ctrl+w or Cmd+t/Cmd+w when the vm is running and ssh connections can be made. However, if the vm is stopped (Terminal tabs are blank with the "Open shell" button), my keyboard shortcuts don't work. Maybe the intents/callback actions need to be in terminal.dart instead of terminal_tabs.dart, I'm not sure.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.94%. Comparing base (b940cde) to head (1c4b526).

Additional details and impacted files

@@                     Coverage Diff                     @@
##           copy-paste-improvements    #3853      +/-   ##
===========================================================
- Coverage                    88.95%   88.94%   -0.01%     
===========================================================
  Files                          256      256              
  Lines                        14584    14584              
===========================================================
- Hits                         12973    12972       -1     
- Misses                        1611     1612       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[andrei-toterman]

Hey, @sharder996! Indeed if the terminal is opened, the shortcuts work. The reason for this is because the shortcuts in that map that you extended are registered only on the widget for the actual terminal view, not for the widget that displays that 'Open shell' button. So if the widget for the terminal view is not built, it won't pick up the shortcuts. I think these shortcuts and intents are not related directly to a single terminal, but to the whole tab collection. So the place where you put the Actions widget is perfect. What I think needs to change is to also introduce a Shortcuts widget to terminal_tabs.dart, so that they are associated to the widget responsible for managing all the tabs, not to every individual terminals.

[andrei-toterman]

Also just a personal experience thing, but the terminal I use uses Ctrl+Shift+T/W, not just Ctrl+T/W. Are others not like that?