get available CPUs and RAM from daemon when launching a new instance in GUI #3867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levkropp
force-pushed
the
daemon-cpu-disk-usage
branch
from
5867f84 to
af771ec
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3867 +/- ##
==========================================
- Coverage 89.03% 89.02% -0.01%
==========================================
Files 255 255
Lines 14577 14583 +6
==========================================
+ Hits 12978 12982 +4
- Misses 1599 1601 +2 ☔ View full report in Codecov by Sentry. |
levkropp
force-pushed
the
daemon-cpu-disk-usage
branch
6 times, most recently
from
bad74f2 to
d29c1fe
Compare
andrei-toterman
requested changes
Jan 7, 2025
levkropp
force-pushed
the
daemon-cpu-disk-usage
branch
from
13c9059 to
9874339
Compare
andrei-toterman
requested changes
Jan 9, 2025
levkropp
force-pushed
the
daemon-cpu-disk-usage
branch
5 times, most recently
from
78439bd to
94d3af8
Compare
andrei-toterman
requested changes
Jan 10, 2025
levkropp
force-pushed
the
daemon-cpu-disk-usage
branch
2 times, most recently
from
a5f591c to
db8d38b
Compare
andrei-toterman
previously approved these changes
Jan 13, 2025
ricab
reviewed
Jan 13, 2025
andrei-toterman
approved these changes
Jan 14, 2025
* edit DaemonInfoReply proto call to have cpus & memory * implement basic cpu and mem usage getter for linux in daemon.cpp * implement basic hook for daemonInfoProvider in providers.dart and launch_form.dart
* cpus is now a uint32 in multipass.proto * removed LinuxSystemInfo struct and replaced with two functions * get_cpus() and get_total_ram() are now platform functions with a linux implementation * configuring a VM's resources now uses daemonInfoProvider properly * cpu, ram, and disk sliders get from daemonInfoProvder in providers.dart instead of their own defined providers
levkropp
force-pushed
the
daemon-cpu-disk-usage
branch
from
64da0bb to
96f5187
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Jan 17, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #3838 by improving how the GUI gets system resource information. Instead of the GUI directly checking system specs (like CPU count and memory size), we now pull that data from the daemon via a new gRPC call. This keeps the logic centralized in the daemon, which already handles disk space reporting, so it makes sense to extend that to cover CPUs and memory as well.
Daemon updates:
_SC_NPROCESSORS_ONLNand_SC_PHYS_PAGES * _SC_PAGESIZEto get CPU count and total ram size respectively. This info is now included in theDaemonInfoReplymessage.GUI changes:
LaunchFormto show available CPUs, memory, and storage in the UI by usingdaemonInfoProvider.