[DPE-4976] Run tests on juju 3.6 on a nightly schedule #173
Conversation
|
Tests pass with juju 2.9/stable, 3.4/stable and 3.6/beta in https://github.com/canonical/mysql-router-operator/actions/runs/10527081121 |
shayancanonical
requested review from
paulomach,
taurus-forever and
carlcsaposs-canonical
| @@ -46,6 +47,7 @@ async def test_ubuntu_pro(ops_test, mysql_router_charm_series, github_secrets): | |||
| application_name=UBUNTU_PRO_APP_NAME, | |||
| channel="latest/edge", | |||
| config={"token": github_secrets["UBUNTU_PRO_TOKEN"]}, | |||
| series=mysql_router_charm_series, | |||
There was a problem hiding this comment.
does series work on 3.6?
There was a problem hiding this comment.
even though series is deprecated, i believe support for series still exists in juju=3.5.2.0 reference
There was a problem hiding this comment.
I'm confused—why did we need to use base on other charms? or was it just that we needed to use base or series?
There was a problem hiding this comment.
I believe we could use either. In this repo, fixtures and CI is deeply tied to series usage. Switching to bases would be a bigger undertaking than this PR
There was a problem hiding this comment.
gotcha 👍
(just wanted to check that series doesn't have the same issue on 3.6 as not having series or base)
There was a problem hiding this comment.
ack, just confirmed that using --series works as expected when deploying in a juju 3.6-beta2 model
There was a problem hiding this comment.
I thought the issue we had was with libjuju and not juju itself? like libjuju was defaulting to focal if base wasn't provided but juju was fine, IIRC
There was a problem hiding this comment.
(that's what I remember from what you said about your findings, I could have misunderstood or be misremembering)
Issue
We would like to run nightly tests with juju 3.6
Solution
Upgrade to dpw v21.0.0 and add juju 3.6 into the matrix for tests. Also, upgrade libjuju to ^3.5.2.0