Deleting an nonexistent certificate request returns 202 Accepted message

[gruyaume]

Describe the bug

Whenever we delete a non-existent certificate request (and perhaps other items) using the HTTP API, we get a 202 Accepted return message.

To Reproduce

1. Create Account
2. Login
3. Delete Certificate Request

Expected behavior

Here we would expect a 404 as the endpoint doesn't exist.

Logs

Request

curl --location --request DELETE 'https://127.0.0.1:3000/api/v1/certificate_requests/4' \
--header 'Authorization: ••••••' \
--data ''

Response:

{
    "result": {
        "message": "success"
    }
}

Environment

• This was tested with the version of Notary on this PR: feat: sign csrs from within Notary #184 but I believe the issue was not introduced here.

[kayra1]

If we delete a nonexistent certificate wouldn't the expected result still be the same :D.

But yes this is because SQL doesn't return anything if no rows matching the query were effected on delete or update operations, we will have to manually check beforehand if we want to differentiate this.