Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Conditional uv vs. tox tests for quality-checks.yaml" #251

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Revert "Conditional uv vs. tox tests for quality-checks.yaml" #251

merged 1 commit into from
Dec 13, 2024

Conversation

MichaelThamm
Copy link
Contributor

@MichaelThamm MichaelThamm commented Dec 13, 2024 •
edited
Loading

Solves #249

This reverts commit 8d3b5c1.
And changes for:

This is causing false negatives in CI and we are also not going with the Make approach anymore except for in Mimir:

@MichaelThamm MichaelThamm requested a review from a team as a code owner December 13, 2024 17:18
@MichaelThamm MichaelThamm merged commit c902fd4 into main Dec 13, 2024
1 check passed
@MichaelThamm MichaelThamm deleted the fix/conditional-ci branch December 13, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abuelodelanada Abuelodelanada Abuelodelanada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelThamm @Abuelodelanada