Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add catalogue + ingress tempo integrations in COS TF module #253

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

michaeldmitry
Copy link
Contributor

@michaeldmitry michaeldmitry commented Dec 18, 2024

Contributes to fixing #245
Adds:

  • tempo:ingress → traefik:traefik_route relation
  • tempo:catalogue → catalogue relation

Context

TODO

Testing Considerations

Create a main.tf file with the following:

# COS module that deploy the whole Canonical Observability Stack
module "cos" {
  source         = "git::https://github.com/canonical/observability//terraform/modules/cos?ref=TAP-158"
  model_name     = var.model_name
  minio_password = var.minio_password
  minio_user     = var.minio_user
}

# S3 module that deploy the Object Storage MinIO required by COS
module "minio" {
  source         = "git::https://github.com/canonical/observability//terraform/modules/minio"
  model_name     = var.model_name
  channel        = var.channel
  minio_user     = var.minio_user
  minio_password = var.minio_password

  loki  = module.cos.loki
  mimir = module.cos.mimir
  tempo = module.cos.tempo
}

variable "channel" {
  description = "Charms channel"
  type        = string
  default     = "latest/edge"
}

variable "model_name" {
  description = "Model name"
  type        = string
}
variable "minio_user" {
  description = "User for MinIO"
  type        = string
}

variable "minio_password" {
  description = "Password for MinIO"
  type        = string
  sensitive   = true
}

And then run:

terraform init 

terraform apply -var='minio_password=mysecretkey' -var='minio_user=myaccesskey' -var='model_name=test'

All units should be in active/idle

@michaeldmitry michaeldmitry requested a review from a team as a code owner December 18, 2024 10:34
@michaeldmitry michaeldmitry changed the title Add catalogue + ingress integrations in COS TF module Add catalogue + ingress tempo integrations in COS TF module Dec 18, 2024
Copy link
Contributor

@sed-i sed-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@@ -40,7 +40,8 @@ module "ssc" {
}

module "tempo" {
source = "git::https://github.com/canonical/observability//terraform/modules/tempo"
# TODO: remove ref before merging
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants