-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kratos rock release #12
base: main
Are you sure you want to change the base?
Conversation
Thanks for this contribution. This seems to be a new ROCK and you're asking for it to be released into DH and ECR, so before even starting the review, I suggest you go through the Contributor's Contract (find the link from last week's workshop) and reach out to @valentincanonical about whether this should be under the "ubuntu" namespace or not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, this image might eventually make it to the Ubuntu namespace as part of Canonical's images portfolio but this will happen later when there's better testing, documentation, and the team is ready to commit to supporting these images.
For now, I suggest removing the release-to / releases options, so that the OCI factory will still build these Rocks but not publish them anywhere beyond the staging GHCR area.
Co-authored-by: Valentin Viennot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for taking the time to comment, but we wanted to merge some disruptive changes before approving this first PR :)
Could you please update the builds.yaml, renaming it to images.yaml and replacing the images
keyword by upload
(according to the new schema)
Hi again! I'm just reviving this thread to know we it should be resumed or closed ;) (FYI @nsklikas ) |
6773854
to
fbad11c
Compare
Add files for the Kratos ROCK
Didn't add any documentation or contacts, hope that's ok.