Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Disabling Security Monitoring #202

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

docs: Disabling Security Monitoring #202

wants to merge 2 commits into from

Conversation

cav72
Copy link

@cav72 cav72 commented Jun 21, 2024

Ping the @canonical/rocks team.

Description

A feature has been added to the ROCKS security monitoring that allows for deprecated tags to be specified and skipped from security email notifications.

@cav72
docs: Disabling Security Monitoring
5c68fa4 
add description and process for disabling security
monitoring for deprecated rocks and deprecated rock tags.

Signed-off-by: Evan Caville <[email protected]>
linostar
linostar requested changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@linostar linostar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nitpick.

IMAGE_MAINTAINER_AGREEMENT.md Outdated Show resolved Hide resolved
@cav72
Copy link
Author

cav72 commented Jun 23, 2024

Just a nitpick.

This is now resolved - let me know if you find any other ones like this. Cheers!

@linostar
Copy link
Contributor

Just a nitpick.

This is now resolved - let me know if you find any other ones like this. Cheers!

Thanks. Can you please edit the author on that commit so it can use your launchpad email instead of the current [email protected] so that the CLA check on the PR passes?

@cav72
Copy link
Author

cav72 commented Jun 24, 2024

Just a nitpick.

This is now resolved - let me know if you find any other ones like this. Cheers!

Thanks. Can you please edit the author on that commit so it can use your launchpad email instead of the current [email protected] so that the CLA check on the PR passes?

done!

@linostar
Copy link
Contributor

Thanks!

There are some changes going to how the documentation generator generates the section of depreacted tags and channels (see PR #203).

This means that oci-factory will be able to auto-list the deprecated tracks in the aforementioned section, and the rock maintainer won't need to write this section manually anymore. The condition for that to happen is based on the end-of-life value for each track of the image.

I suggest to wait until PR #203 is merged then adjust this PR accordingly to reflect those changes.

@cav72
Copy link
Author

cav72 commented Jun 26, 2024

Roger that! Sounds like a plan

@cav72
Copy link
Author

cav72 commented Sep 12, 2024

hi @linostar - I was wondering if had any info on the status of #203 to allow this MR to get merged?

@linostar
Copy link
Contributor

linostar commented Sep 12, 2024 •
edited
Loading

hi @linostar - I was wondering if had any info on the status of #203 to allow this MR to get merged?

Hey. Thanks for a following up. PR #203 was blocked by PR #241, which is hopefully going to be merged in the few upcoming days. Once that done, PR #203 can be merged too and ublock this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linostar linostar linostar requested changes

Assignees
No one assigned
Labels
do-not-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cav72 @linostar @cjdcordeiro