Fix CLI Client Handling Non-Interactive Terminal and Error Message for Non-Canonical Repo #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linostar
requested changes
Sep 20, 2024
Co-authored-by: Linostar <[email protected]>
zhijie-yang
commented
Sep 20, 2024
| @@ -49,12 +49,16 @@ func InferBuildMetadata() BuildMetadata { | |||
| // use regex to match the repo location | |||
| regex := regexp.MustCompile("github.com[:/](canonical/.*).git") | |||
There was a problem hiding this comment.
We should only match "Push URL: ..." (even without ".git"), because there can be the case the the developer pulls from upstream and updates the repo in canonical. (Suggested by @clay-lake )
| if len(matches) < 2 { | ||
| fmt.Fprintf(os.Stderr, "oci-factory must be called in a git local repository under organization [canonical]\n") | ||
| os.Exit(1) | ||
| } | ||
| source := matches[1] |
There was a problem hiding this comment.
Then we should use matches[0] and if len(matches) == 1 to match with this change.
cjdcordeiro
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ping the @canonical/rocks team.
Description
This PR fixes the following issues: