Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add canonical-iam as maintainer to use oci-factory cli on login-ui #278

Merged
merged 1 commit into from
Nov 6, 2024
Merged

fix: add canonical-iam as maintainer to use oci-factory cli on login-ui #278

merged 1 commit into from
Nov 6, 2024

Conversation

shipperizer
Copy link
Contributor

@shipperizer shipperizer commented Nov 5, 2024 •
edited
Loading

adding canonical-iam as maintainer for login-ui

split from #274

@shipperizer shipperizer requested a review from a team as a code owner November 5, 2024 15:55
zhijie-yang
zhijie-yang approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@zhijie-yang zhijie-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

One nitpick: An empty line at the end of the file would make the formatting better.

@zhijie-yang zhijie-yang merged commit 0152847 into canonical:main Nov 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhijie-yang zhijie-yang zhijie-yang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shipperizer @zhijie-yang