Skip to content

Commit

Permalink
ci: don't cancel other unit tests when one fails (#1471)
Browse files Browse the repository at this point in the history
A test can pass on one python/os version and fail on others, and it’s
nice to see that in the outcome, rather than dig into cancelled tests
which may or may not have hit the failing case.

Since unit tests are cheap and fast, we’re not really saving much by
cancelling them – by the time one unit test run fails and asks the
others to cancel, they’ll already have been spun up and run many of the
tests, so cancelling them doesn't save much.

The pip-install and test-real-pebble jobs are faster than the test job,
so this commit adds fail-fast: false to them too.
  • Loading branch information
james-garner-canonical authored Dec 16, 2024
1 parent d4aadba commit 4e856c9
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/framework-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ jobs:
runs-on: ${{ matrix.os }}

strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest]
python-version: ["3.8", "3.10", "3.12"]
Expand All @@ -66,6 +67,7 @@ jobs:
runs-on: ${{ matrix.os }}

strategy:
fail-fast: false
matrix:
os: [ubuntu-latest]
python-version: ["3.8", "3.10", "3.12"]
Expand Down Expand Up @@ -107,6 +109,7 @@ jobs:
runs-on: ${{ matrix.os }}

strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest]
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]
Expand Down

0 comments on commit 4e856c9

Please sign in to comment.