Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: correctly point PyPI publishing to the ops-scenario packages #1514

Merged

Conversation

tonyandrewmeyer
Copy link
Contributor

working-directory is specifically for run steps. For the gh-action-pypi-publish action, with: packages-dir should be used.

@tonyandrewmeyer
Copy link
Contributor Author

I'm not sure how to test this pre-merge (to avoid it being wrong again, although I've gone through the documentation more carefully this time). I can't run the action against this branch, and I can't run the action in my fork (because the trusted publishing system requires it to be from the real repo). Suggestions welcome!

@tonyandrewmeyer tonyandrewmeyer marked this pull request as ready for review December 18, 2024 20:57
Copy link
Contributor

@james-garner-canonical james-garner-canonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the best way to test will be to run the test pypi job manually after merging this

Copy link
Contributor

@dimaqq dimaqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re testing: push to test pypi from a branch with made up package version.

Edit: I guess that requires setting secrets for the branch and possibly tweaking the test.pypi trusted publishing temprarily?

@tonyandrewmeyer tonyandrewmeyer merged commit 9bc00c6 into canonical:main Jan 8, 2025
32 checks passed
@tonyandrewmeyer tonyandrewmeyer deleted the fix-publish-workflow branch January 8, 2025 20:35
@tonyandrewmeyer
Copy link
Contributor Author

Tested and [works fine] 🎉 - I'm reasonably confident that this means that publishing to actual PyPI will also be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants