Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: expand the reference documentation #169
docs: expand the reference documentation #169
Changes from 2 commits
617897f
1a0e7d3
abefd19
8ecf842
09a96bf
a6a3e1d
216a985
a68601c
4a953e1
b92bc7b
f241c5f
b3a1dde
ac36272
33a418a
45d8cec
de44f35
08e0644
1ba60c6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we promote scenario as another way to do unit tests, then? We should sync with Charmcraft to make sure their profiles create a directory structure for tests that is aligned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're (imminently) going to be promoting Scenario as the preferred way to do unit tests. I also tried to have these work if you were reading them when you'd done
pip install ops-scenario
but also if you had donepip install ops[testing]
and were getting all the classes from theops.testing
namespace. This is also why all the references to the name "scenario" in the docs are gone.I do have a ticket for updating the charmcraft profiles. I need to get all the bits in places first, but it's definitely in my definition-of-done.