Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vroot cleanup #61

Merged
merged 6 commits into from
Sep 19, 2023
Merged

vroot cleanup #61

merged 6 commits into from
Sep 19, 2023

Conversation

PietroPasotti
Copy link
Collaborator

implemented vroot cleanup:

  • scenario now allows metadata.yaml to be present in user-given vroot. if you pass meta to scenario.Context, metadata.yaml will be overwritten (and when Context is done, it will be restored to its previous state!). Same for actions and config.yaml.

  • scenario now cleans up after itself: if it created any metadata files, it will delete them.

Copy link
Collaborator

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor comments, but looks fine to me.

One other thing I'd say is that "vroot" doesn't have much meaning to me (and isn't a term in ops). I think we should say "charm root" in any user-facing comments/docs.

scenario/runtime.py Outdated Show resolved Hide resolved
scenario/runtime.py Outdated Show resolved Hide resolved
scenario/runtime.py Outdated Show resolved Hide resolved
@PietroPasotti PietroPasotti merged commit 0cd0c15 into main Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants