This repository has been archived by the owner on Oct 16, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Removed the unneeded ones!. Thanks for the comment. |
jdkandersson
previously approved these changes
Sep 10, 2024
amandahla
reviewed
Sep 11, 2024
amandahla
reviewed
Sep 11, 2024
amandahla
previously approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Test coverage for 8fbcc59
Static code analysis report
|
arturo-seijas
approved these changes
Sep 11, 2024
amandahla
approved these changes
Sep 11, 2024
github-merge-queue bot
pushed a commit
to canonical/charmcraft
that referenced
this pull request
Sep 18, 2024
RabbitMQ is already in paas-app-charmer (see canonical/paas-app-charmer#39). Add RabbitMQ requires to init templates (commented out) so it is easier for the user to be able to uncomment it if needed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable spec: ISD175 - RabbitMQ support in paas-charm
Overview
Support RabbitMQ in paas-app-charmer.
There are two different charms that provider RabbitMQ, rabbitmq-server and rabbitmq-k8s. A new library has done, based on the one in rabbitmq-k8s,
paas_app_charmer.rabbitmq.RabbitMQRequires
that provides a common interface to both charms, and provides aRabbitMQParameters
model with the rabbitmq information. This is the same as the one in the charm state, as that library is just use in this project.Documentation will be done outside of this PR.
fetch-lib
has been changed everywhere tofecth-libs
as charmcraft stable already offersfecth-libs
.Rationale
Juju Events Changes
Module Changes
Library Changes
Checklist
src-docs
urgent
,trivial
,complex
)