Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tempo tracing #20

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Tempo tracing #20

wants to merge 13 commits into from

Conversation

alithethird
Copy link
Contributor

@alithethird alithethird commented Dec 16, 2024

Overview

Adds new integration Tempo to the charm. Creates a class called TempoParameters that handles the parameters. There are only 2 parameters:

  • Endpoint
  • Service name

Endpoint comes from the integration and service name is generated by reading the charm name from the charmcraft.yaml file.

Rationale

Juju Events Changes

Module Changes

Library Changes

Checklist

@canonical canonical deleted a comment from github-actions bot Dec 18, 2024
@alithethird alithethird marked this pull request as ready for review December 18, 2024 08:00
@alithethird alithethird requested a review from a team as a code owner December 18, 2024 08:00
src/paas_charm/app.py Outdated Show resolved Hide resolved
src/paas_charm/charm.py Outdated Show resolved Hide resolved
src/paas_charm/charm.py Outdated Show resolved Hide resolved
src/paas_charm/charm.py Outdated Show resolved Hide resolved
src/paas_charm/charm.py Outdated Show resolved Hide resolved
src/paas_charm/charm_state.py Outdated Show resolved Hide resolved
src/paas_charm/charm_state.py Outdated Show resolved Hide resolved
src/paas_charm/charm_state.py Outdated Show resolved Hide resolved
src/paas_charm/charm_state.py Outdated Show resolved Hide resolved
Copy link
Contributor

Test coverage for ca89e47

Name                                          Stmts   Miss Branch BrPart  Cover   Missing
-----------------------------------------------------------------------------------------
src/paas_app_charmer/__init__.py                  2      0      0      0   100%
src/paas_app_charmer/django/__init__.py           2      0      0      0   100%
src/paas_app_charmer/django/charm.py              2      0      0      0   100%
src/paas_app_charmer/fastapi/__init__.py          2      0      0      0   100%
src/paas_app_charmer/fastapi/charm.py             2      0      0      0   100%
src/paas_app_charmer/flask/__init__.py            2      0      0      0   100%
src/paas_app_charmer/flask/charm.py               2      0      0      0   100%
src/paas_app_charmer/go/__init__.py               2      0      0      0   100%
src/paas_app_charmer/go/charm.py                  2      0      0      0   100%
src/paas_charm/__init__.py                       32     17      0      0    47%   13-14, 19-20, 26-27, 33-37, 43-44, 50-51, 57-58
src/paas_charm/_gunicorn/__init__.py              0      0      0      0   100%
src/paas_charm/_gunicorn/charm.py                42      0      6      0   100%
src/paas_charm/_gunicorn/webserver.py            91      4     16      1    95%   207, 219-225
src/paas_charm/_gunicorn/workload_config.py       8      0      0      0   100%
src/paas_charm/_gunicorn/wsgi_app.py             21      0      2      0   100%
src/paas_charm/app.py                           171      0     62      5    98%   113->exit, 170->176, 280->282, 282->285, 363->365
src/paas_charm/charm.py                         282     27     62      4    90%   35-36, 43-44, 51-52, 274, 284-285, 287-288, 317-321, 389, 488-489, 494, 499, 504, 514, 519, 524, 529, 534, 559, 594
src/paas_charm/charm_state.py                   111      2     12      2    97%   280, 376
src/paas_charm/charm_utils.py                    23      0      0      0   100%
src/paas_charm/database_migration.py             35      0      2      0   100%
src/paas_charm/databases.py                      25      2      6      1    90%   89-90
src/paas_charm/django/__init__.py                 2      0      0      0   100%
src/paas_charm/django/charm.py                   50      4      8      2    90%   49, 124, 139-140
src/paas_charm/exceptions.py                      5      0      0      0   100%
src/paas_charm/fastapi/__init__.py                2      0      0      0   100%
src/paas_charm/fastapi/charm.py                  31      0      0      0   100%
src/paas_charm/flask/__init__.py                  2      0      0      0   100%
src/paas_charm/flask/charm.py                    26      0      0      0   100%
src/paas_charm/framework.py                      23      4     12      2    77%   36, 49-51
src/paas_charm/go/__init__.py                     2      0      0      0   100%
src/paas_charm/go/charm.py                       28      0      0      0   100%
src/paas_charm/observability.py                  24      3      4      1    86%   42->46, 73-77
src/paas_charm/rabbitmq.py                       78      2     22      5    93%   117->exit, 122->exit, 157->exit, 159-160, 181->175
src/paas_charm/secret_storage.py                 50      2     14      4    91%   55->54, 56->58, 86, 105
src/paas_charm/utils.py                          44      7     14      5    79%   34, 36, 56-57, 75, 79, 104
-----------------------------------------------------------------------------------------
TOTAL                                          1226     74    242     32    93%

Static code analysis report

Run started:2024-12-19 09:57:40.495147

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 2598
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 2

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants