-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debian: Added support for versions 10, 11 and 12 #162
Conversation
preventing builds to fail.
preventing builds to fail.
years, added some comments and moved clean-up commands to its respective script.
10 (Buster), 11 (Bullseye) & 12 (Bookworm) support. Closes canonical#24
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome contribution, but this needs some cleanup
- remove changes to the
ubuntu
template, I believe they belong to another PR - remove unused scripts from
debian/scripts
, I think they were copied fromubuntu
but not required by the image you are building.
These changes have been applied. |
@alanbach Did your changes make it into the PR? Github is claiming that you still have changes to Ubuntu in the PR. |
@proegssilb I don't know why changes that were a part of a different PR are showing up here. Those are already merged and this looks to me some sort of a snag. |
Looks like that merge cleaned up the Ubuntu changes. Didn't check the scripts, but hopefully this PR can be re-reviewed soon. Thanks alanbach! |
Yup, the branch re-sync cleaned it up. Give this a try and let me know if you hit any issues! Hopefully we can get this merged soon. |
Still working on troubleshooting my setup. I'll post if there's any issues, but I wouldn't advise using my difficulties as an excuse to delay this PR. I probably just need to read through the README and logs in more detail until I can figure out what's going on. And then maybe we can update the README in a future PR. |
also trying to use this template to build debian arm64 maas images. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using this template for ARM64 architecture would require some minor changes.
MAAS snap latest/edge (thus 3.5.0-alpha1), with packer-maas on your PR-24 branch. Trying to dig why. |
btw, /var/snap/maas/current/preseeds/curtin_userdata_custom breaks known to work tweaked ubuntu image deployment, works again with file removed. Don’t know MAAS internals enough to know if a conditional (on uname or something ?) would do the trick to prevent other OSes breakage. |
you can name the preseed as |
Can we get this into the readme, or link to the relevant documentation from the readme? |
works fine ! Thanks for the tip @alexsander-souza 👍 |
Good catch with lvm/xfsprogs. I'll get that fixed. |
conflicts and updated the upload command.
Done. |
customize_script in the main README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's expand these wrappers, otherwise it's hard to tell what the template is doing
that needs to be baked into the images by default.
Lightly tested commit 319fc01 . Compiling amd64 images via |
Thank you. Currently working on completing the arm64 support. |
Extra README.md clean-ups and additions.
OK, just tested building and deploying arm64 Buster, Bullseye and Bookworm images. They all worked, just a small note that the preseed file needs to be updated for arm64 since the kernel package name is linux-image-arm64. Updated the README file and included a separate ready to use arm64 preseed file as well. Please try out the new changes and let me know if you see any issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
quick test, bookworm installed and worked fine on x86_64 with your latest commits ! thanks a lot @alanbach |
Debian 11 worked too. 10 fails like on yesterday photos. |
Added experimental support for Debian 10 (Buster), 11 (Bullseye) & 12 (Bookworm).
Closes #24