Run unit tests only on Go 1.20 #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhoyt
reviewed
Aug 2, 2023
anpep
approved these changes
Aug 2, 2023
There was a problem hiding this comment.
My review was not requested here, but I wanted to chip in since I was mentioned in the matrix discussion.
I think we should test only the Go version in the go.mod file. Testing multiple versions only adds more running time to the CI and does not provide much value since, as previously discussed, the semantics of the version stated in go.mod are used regardless.
Also, these changes look good to me (: I'd be fine with removing the matrix but the current approach is functionally equivalent so I'd say let's stick to that until there's a more general consensus on the matter!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As established in #171, Pebble no longer needs to support Go versions before Go 1.20. Hence, it no longer makes sense to run the unit tests with Go versions before 1.20.