test(servstate): enhance checkstate and reaper tests #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 18, 2023
benhoyt
approved these changes
Aug 21, 2023
The following tests had a check which relied on the checkstate failure counter: TestOnCheckFailureRestartWhileRunning TestOnCheckFailureIgnore TestOnCheckFailureShutdown However, this counter increments every time after the check timeout expires, even after the service was notified (which happens once only). This counter is a detail that is covered by the checkstate unit tests. Expecting an exact value from the async testing thread makes the test timing sensitive and racey, without adding any value from the servstate package perspective. Change the failure counter check to >= 1 to remove timing sensitivity from the following tests.
TestReapZombies have some timing sensitive code which can result in CI failures under heavy CPU load. This PR adds a file based trigger mechanism to ensure there is a controlled window of opportunity to: - Read the grandchild PID from the child process stdout. - Observe the grandchild process in zombie status before its reaped.
flotter
force-pushed
the
servstate-more-races
branch
from
c269bc3
to
f4b841f
Compare
benhoyt
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following commits are included:
test(servstate): enhance zombie reaper test
TestReapZombies have some timing sensitive code which can result in CI failures under heavy CPU load.
This PR adds a file based trigger mechanism to ensure there is a controlled window of opportunity to:
test(servstate): remove checks related races
The following tests had a check which relied on the checkstate failure counter:
However, this counter increments every time after the check timeout expires, even after the service was notified (which happens once only). This counter is a detail that is covered by the checkstate unit tests. Expecting an exact value from the async testing thread makes the test timing sensitive and racey, without adding any value from the servstate package perspective.
Change the failure counter check to >= 1 to remove timing sensitivity from the following tests.