fix(cli): PEBBLE_COPY_ONCE on missing dir. #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpidcock
changed the title
hpidcock
changed the title
|
@benhoyt we will need a |
hpidcock
changed the title
benhoyt
approved these changes
Mar 21, 2024
benhoyt
added a commit
to benhoyt/pebble
that referenced
this pull request
Mar 21, 2024
If the `PEBBLE_COPY_ONCE` source directory does not exist, it will fail to copy inside the borrowed std go copyFS function. This adds an `os.Stat` to check if it first exists, ignoring it otherwise (the expected behavior). --------- Co-authored-by: Ben Hoyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
PEBBLE_COPY_ONCEsource directory does not exist, it will fail to copy inside the borrowed std go copyFS function. This adds anos.Statto check if it first exists, ignoring it otherwise (the expected behavior).