Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: how to manage service dependencies #457

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Conversation

AnneCYH
Copy link
Contributor

@AnneCYH AnneCYH commented Jul 24, 2024

No description provided.

@IronCore864 IronCore864 changed the title Suggested edits for how-to docs: how to manage service dependencies Jul 24, 2024
@AnneCYH AnneCYH force-pushed the master branch 2 times, most recently from bb62f6e to 7c831cb Compare July 24, 2024 07:08
@AnneCYH AnneCYH marked this pull request as ready for review July 24, 2024 07:10
@IronCore864
Copy link
Contributor

I have reviewed Anne's suggestions in detail and we discussed them on a 1-1 call.

FYI @benhoyt we decided to merge this PR first because the structural change is quite much and it would be more difficult to merge this one into my PR than to merge mine into the main.

After this PR is merged, in my original PR, I will rebase it on Anne's work, then add references for service dependencies and start orders, and add the links in the how-to.

Copy link
Contributor

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Requesting a few minor changes.

docs/how-to/service-dependencies.md Outdated Show resolved Hide resolved
docs/how-to/service-dependencies.md Outdated Show resolved Hide resolved
docs/how-to/service-dependencies.md Outdated Show resolved Hide resolved
docs/how-to/service-dependencies.md Outdated Show resolved Hide resolved
docs/how-to/service-dependencies.md Outdated Show resolved Hide resolved
- Changed overall tone of how-to guide
- Used action verbs for headings
- Removed explanation sections to be covered in References
- Restructured content to avoid overly narrow use case
@AnneCYH
Copy link
Contributor Author

AnneCYH commented Jul 26, 2024

Hi @benhoyt , I've addressed all your comments but left one conversation open for your review.

Thanks.

@benhoyt benhoyt merged commit 3f94454 into canonical:master Jul 26, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants