-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: how to manage service dependencies #457
Conversation
bb62f6e
to
7c831cb
Compare
I have reviewed Anne's suggestions in detail and we discussed them on a 1-1 call. FYI @benhoyt we decided to merge this PR first because the structural change is quite much and it would be more difficult to merge this one into my PR than to merge mine into the main. After this PR is merged, in my original PR, I will rebase it on Anne's work, then add references for service dependencies and start orders, and add the links in the how-to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Requesting a few minor changes.
- Changed overall tone of how-to guide - Used action verbs for headings - Removed explanation sections to be covered in References - Restructured content to avoid overly narrow use case
Hi @benhoyt , I've addressed all your comments but left one conversation open for your review. Thanks. |
No description provided.