[MISC] Disable juju 3.6 tests #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
=======================================
Coverage 75.01% 75.01%
=======================================
Files 9 9
Lines 1313 1313
Branches 238 238
=======================================
Hits 985 985
Misses 255 255
Partials 73 73 ☔ View full report in Codecov by Sentry. |
dragomirp
commented
Jan 7, 2025
| @@ -29,7 +29,8 @@ parts: | |||
| rustup default stable | |||
|
|
|||
| # Convert subset of poetry.lock to requirements.txt | |||
| curl -sSL https://install.python-poetry.org | python3 - | |||
| curl -sSL https://install.python-poetry.org | python3 - --version 1.8.5 | |||
There was a problem hiding this comment.
Poetry 2 drops support for Python 3.8. Hardcoding since we will be changing this when migrating to Charmcraft 3 poetry plugin.
dragomirp
requested review from
a team,
taurus-forever,
marceloneppel and
lucasgameiroborges
and removed request for
a team
marceloneppel
approved these changes
Jan 7, 2025
taurus-forever
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are issues with TLS on juju 3.6. Disabling for now to reenable CI on main.
Updating libs