[DPE-3684] Implement DA139 #663
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dpe-3684-reinitialise-raft #663 +/- ##
==============================================================
- Coverage 72.15% 71.78% -0.38%
==============================================================
Files 15 15
Lines 3426 3466 +40
Branches 528 536 +8
==============================================================
+ Hits 2472 2488 +16
- Misses 827 846 +19
- Partials 127 132 +5 ☔ View full report in Codecov by Sentry. |
dragomirp
changed the title
dragomirp
commented
Jan 23, 2025
Comment on lines
-109
to
-111
| self.framework.observe( | ||
| self.charm.on.promote_to_primary_action, self._on_promote_to_primary | ||
| ) |
There was a problem hiding this comment.
Moved to the main charm code, since it's no longer used only for async promotion.
dragomirp
commented
Jan 23, 2025
Comment on lines
-865
to
-874
| try: | ||
| health_status = self.get_patroni_health() | ||
| except Exception: | ||
| logger.warning("Remove raft member: Unable to get health status") | ||
| health_status = {} | ||
| if health_status.get("role") in ("leader", "master") or health_status.get( | ||
| "sync_standby" | ||
| ): | ||
| logger.info(f"{self.charm.unit.name} is raft candidate") | ||
| data_flags["raft_candidate"] = "True" |
There was a problem hiding this comment.
Wait for the action to start reinit
dragomirp
commented
Jan 23, 2025
| @@ -746,15 +747,18 @@ def stop_patroni(self) -> bool: | |||
| logger.exception(error_message, exc_info=e) | |||
| return False | |||
|
|
|||
| def switchover(self) -> None: | |||
| def switchover(self, candidate: str | None = None) -> None: | |||
There was a problem hiding this comment.
Pass a candidate when promoting a specific unit.
dragomirp
commented
Jan 24, 2025
| for unit in units: | ||
| logger.info(f"Stopping unit {unit}") | ||
| await stop_machine(ops_test, await get_machine_from_unit(ops_test, unit)) | ||
| await sleep(15) |
There was a problem hiding this comment.
Sleep for the Juju leadership to drift.
dragomirp
commented
Jan 24, 2025
Comment on lines
+109
to
+114
| # Check if Patroni self healed | ||
| assert ( | ||
| left_unit.workload_status == "active" | ||
| and left_unit.workload_status_message == "Primary" | ||
| ) | ||
| logger.warning(f"Patroni self-healed without raft reinitialisation for roles {roles}") |
There was a problem hiding this comment.
Sometimes when removing the primary and async replica, Patroni manages to survive, so adding an exception for this case. Should I nail it down further?
dragomirp
requested review from
a team,
taurus-forever,
marceloneppel and
lucasgameiroborges
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement DA139:
promote-to-primaryto promote units and reinitialise RAFT