Make probert buildable again on noble #147
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to install a freshly built console-conf but it requires probert-network which FTBFS on noble, even when building with
nocheck
. I decided to fix it.The main reason for the build failure was files in debian/tmp that were not included in any binary package.nvme.py -> now included in probert-storageos.py -> now included in probert-storagetest scripts and test data. This is not clear to me why we ship those in probert-common but doing so fixed the build issue so 🤷dumpe2fs_ext4.outntfsresize.outntfsresize_full.outtest_filesystem.pytest_os.pyWhen building without
nocheck
, there were tests failing because:python3-parameterized was not declared as a Build-DependAdded as a Build-Depend now.shutil.which
to check their presence.shutil.which
.I took the opportunity to mark the test-only build depends as
<!nocheck>