Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Devel/disallow forks #1814

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

[WIP] Devel/disallow forks #1814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
d70cbba
feat: forked repo test
yanksyoon Jun 17, 2024
9b7a25c
test: fixture name
yanksyoon Jun 17, 2024
983ab55
skip charm lib lint
yanksyoon Jun 17, 2024
c302818
fix type hints
yanksyoon Jun 17, 2024
682ed87
fix typo
yanksyoon Jun 17, 2024
6de59fb
fix fixtures
yanksyoon Jun 17, 2024
de79361
test: fix indirect
yanksyoon Jun 17, 2024
53cf18e
test: fix explicit None
yanksyoon Jun 17, 2024
61cd386
test: test disallow forks
yanksyoon Jun 17, 2024
04035b4
test: test blueprint get document
yanksyoon Jun 17, 2024
7fe4025
test: fix dict unpack
yanksyoon Jun 17, 2024
3a6de13
test: false fix
yanksyoon Jun 17, 2024
8b24220
rename forks to fork
yanksyoon Jun 17, 2024
c25b84b
increment app version
yanksyoon Jun 17, 2024
fe9a0cc
test config changed
yanksyoon Jun 18, 2024
db30a16
test config changed
yanksyoon Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/integration_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,5 @@ jobs:
charmcraft-channel: latest/edge
test-tox-env: charm-integration-test
trivy-image-config: "trivy.yaml"
tmate-debug: true
tmate-timeout: 60
7 changes: 7 additions & 0 deletions charm/charmcraft.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,13 @@ config:
generate the subsequent one-time token authentication.
type: string
required: true
disallow_fork_pull_request:
description: >-
Disable forked repository access to job runs.
This is used to protect private-endpoint runners for security purposes. Blocks all pull
request runs from a forked repository.
type: boolean
default: false
github_token:
description: >-
The token to use for comms with GitHub. This can be a PAT or a fine-grained token
Expand Down
Loading
Loading