Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: specify the configuration path to use NRF version 1.6.0 #430

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

gatici
Copy link
Contributor

@gatici gatici commented Dec 6, 2024

Description

TLS paths and the configuration paths are parameterized in the Upstream with NRF version 1.6.0.
To use the Workload 1.6.0 and higher versions, this PR which specifies configuration and TLS file paths is required.

Warning: A new Rock version (1.6.0 or higher) should be used with this PR. Integration tests fails until we create a new Rock version and start to use it.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@gatici gatici requested a review from a team as a code owner December 6, 2024 14:40
Copy link
Contributor

@Gmerold Gmerold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.6 NRF ROCK is available.

@gatici
Copy link
Contributor Author

gatici commented Dec 10, 2024

1.6 NRF ROCK is available.
I am waiting for 1.6.1 version to be published by Gabriel today or tomorrow.

@gatici gatici force-pushed the specify-configuration-files branch from 7cf0be1 to 775d28c Compare December 11, 2024 14:32
@gatici gatici requested review from Gmerold and a team December 11, 2024 16:03
@gatici gatici merged commit f365f70 into main Dec 11, 2024
27 checks passed
@gatici gatici deleted the specify-configuration-files branch December 11, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants