Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Change the interface name from fiveg-nrf to fiveg_nrf #74

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

gatici
Copy link
Contributor

@gatici gatici commented Feb 14, 2024

Description

NRF and AMF use different relation names for fiveg_nrf interface. All the other charms uses fiveg_nrf. We need to use the same naming convention in all charms. For this reason interface name is changed from fiveg-nrf -> fiveg_nrf within this PR.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@gatici gatici requested a review from a team as a code owner February 14, 2024 11:21
@gatici gatici force-pushed the TELCO-980-Use-same-name-for-fiveg-nrf-interface branch from a898a23 to befb057 Compare February 14, 2024 11:22
@gatici gatici merged commit f885155 into main Feb 14, 2024
12 checks passed
@gatici gatici deleted the TELCO-980-Use-same-name-for-fiveg-nrf-interface branch February 14, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants