Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use 1.5.0 version of rocks #434

Merged
merged 2 commits into from
Nov 27, 2024
Merged

fix: Use 1.5.0 version of rocks #434

merged 2 commits into from
Nov 27, 2024

Conversation

ghislainbourgeois
Copy link
Contributor

Description

Bump the version of the rocks used to 1.5.0. Depends on canonical/sdcore-upf-bess-rock#36

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@ghislainbourgeois ghislainbourgeois requested a review from a team as a code owner November 27, 2024 16:25
gruyaume
gruyaume reviewed Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@gruyaume gruyaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR and #433 seem to conflict

@ghislainbourgeois ghislainbourgeois mentioned this pull request Nov 27, 2024
Closed
7 tasks
@ghislainbourgeois ghislainbourgeois merged commit 87ddc19 into main Nov 27, 2024
30 checks passed
@ghislainbourgeois ghislainbourgeois deleted the fix-rock-versions branch November 27, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gruyaume gruyaume gruyaume left review comments

@patriciareinoso patriciareinoso patriciareinoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghislainbourgeois @patriciareinoso @gruyaume