Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Uses [email protected] in TF module #452

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

Gmerold
Copy link
Contributor

@Gmerold Gmerold commented Dec 18, 2024

Description

This PR fixes TELCO-1544

CONTEXT:
By default, Juju fetches charms with base matching the host OS. It means that when running Jammy, Juju won’t use latest charms, because we’ve changed the base to Noble.

Adding an optional (as per CC006) config param base will allow using Noble (base should be set to [email protected]) regardless of the host OS.

Enforcing Noble on a Juju model configuration level is not an option, because it breaks COS integration (COS charms are not available in [email protected]

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@Gmerold Gmerold requested a review from a team as a code owner December 18, 2024 07:55
@Gmerold Gmerold merged commit 16916ff into main Dec 18, 2024
17 checks passed
@Gmerold Gmerold deleted the TELCO-1544-specify-base branch December 18, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants