Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Use handle_exec instead of mocking container exec method #59

Merged
merged 2 commits into from
Nov 24, 2023
Merged

chore: Use handle_exec instead of mocking container exec method #59

merged 2 commits into from
Nov 24, 2023

Conversation

dariofaccin
Copy link
Contributor

@dariofaccin dariofaccin commented Nov 17, 2023 •
edited
Loading

Description

This PR aims to replace mock objects for ops.model.Container.exec, leveraging the new ops.harness.handle_exec method.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@dariofaccin dariofaccin changed the title First draft for handle_exec usage feat: Use handle_exec instead of mocking container exec method Nov 17, 2023
@gruyaume gruyaume requested a review from benhoyt November 20, 2023 12:21
gruyaume
gruyaume reviewed Nov 20, 2023
View reviewed changes
tests/unit/test_charm.py Outdated Show resolved Hide resolved
@dariofaccin dariofaccin changed the title feat: Use handle_exec instead of mocking container exec method chore: Use handle_exec instead of mocking container exec method Nov 20, 2023
@dariofaccin dariofaccin force-pushed the TELCO-883-use-handle-exec branch from 5f416d8 to be8f553 Compare November 21, 2023 09:36
@dariofaccin dariofaccin marked this pull request as ready for review November 21, 2023 10:30
@dariofaccin dariofaccin requested a review from a team as a code owner November 21, 2023 10:30
gatici
gatici approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@gatici gatici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dariofaccin dariofaccin merged commit acf337c into main Nov 24, 2023
26 checks passed
@dariofaccin dariofaccin deleted the TELCO-883-use-handle-exec branch November 24, 2023 09:45
@gruyaume gruyaume mentioned this pull request Nov 28, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gatici gatici gatici approved these changes

@gruyaume gruyaume gruyaume approved these changes

@benhoyt benhoyt Awaiting requested review from benhoyt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dariofaccin @benhoyt @gruyaume @gatici