Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rename SD-Core charms by adding -k8s as a suffix #66

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

gatici
Copy link
Contributor

@gatici gatici commented Dec 6, 2023

Description

Add -k8s as a suffix in both github and Charmhub name to follow TE042 .

  • Create new fiveg_n3 and fiveg_n4 libraries
  • Pin macaroonbakery to 1.3.2 which installed by juju client indirectly through pytest_operator.
    - The next protobuf version 4.21.0 has the breaking changes with the existing code
    - https://protobuf.dev/news/2022-05-06/#python-updates

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@gatici gatici requested a review from a team as a code owner December 6, 2023 10:51
Copy link
Contributor

@Gmerold Gmerold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments in NRF #57 and NSSF #35

@gatici gatici force-pushed the TELCO-921-follow-charm-naming-convention branch from 7d6abdb to c771637 Compare December 8, 2023 13:17
Pin macaroonbakery to 1.3.2
The next protobuf version 4.21.0 has the breaking changes with the existing code
https://protobuf.dev/news/2022-05-06/#python-updates

Signed-off-by: gatici <[email protected]>
@gatici gatici force-pushed the TELCO-921-follow-charm-naming-convention branch from c771637 to e78c1cb Compare December 8, 2023 13:49
@gatici gatici merged commit 2e70624 into main Dec 11, 2023
23 checks passed
@gatici gatici deleted the TELCO-921-follow-charm-naming-convention branch December 11, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants