Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move to Blocked state when HugePages are not available #69

Merged

Conversation

dariofaccin
Copy link
Contributor

Description

This PR adds two validations to the UPF charm when enabling HugePages: the first is the support of the required CPU flags (pdpe1gb); the second is the capacity of enough HugePages (2Gi) on the K8S nodes. If the free HugePages (allocatable minus allocated) are not enough, the charm will remain in Waiting status.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@dariofaccin dariofaccin requested a review from a team as a code owner December 11, 2023 17:03
@dariofaccin dariofaccin force-pushed the TELCO-914-move-to-blocked-when-hugepages-not-available branch from 5859e17 to fd53c5d Compare December 11, 2023 17:03
src/charm.py Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Gmerold Gmerold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description says:
(...) If the free HugePages (allocatable minus allocated) are not enough, the charm will remain in Waiting status.
The code only checks the capacity tho. I think it would be great to have the feature implemented as described above.

@dariofaccin dariofaccin force-pushed the TELCO-914-move-to-blocked-when-hugepages-not-available branch from fd53c5d to 32492f0 Compare December 13, 2023 09:27
@dariofaccin dariofaccin force-pushed the TELCO-914-move-to-blocked-when-hugepages-not-available branch from 3374e96 to ad32f63 Compare December 14, 2023 08:27
@dariofaccin dariofaccin requested a review from gruyaume December 14, 2023 08:27
@dariofaccin dariofaccin force-pushed the TELCO-914-move-to-blocked-when-hugepages-not-available branch from ad32f63 to 244e8be Compare January 3, 2024 14:04
@dariofaccin dariofaccin merged commit 6649241 into main Jan 3, 2024
23 checks passed
@dariofaccin dariofaccin deleted the TELCO-914-move-to-blocked-when-hugepages-not-available branch January 3, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants