-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move to Blocked state when HugePages are not available #69
Merged
dariofaccin
merged 8 commits into
main
from
TELCO-914-move-to-blocked-when-hugepages-not-available
Jan 3, 2024
Merged
fix: move to Blocked state when HugePages are not available #69
dariofaccin
merged 8 commits into
main
from
TELCO-914-move-to-blocked-when-hugepages-not-available
Jan 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariofaccin
force-pushed
the
TELCO-914-move-to-blocked-when-hugepages-not-available
branch
from
December 11, 2023 17:03
5859e17
to
fd53c5d
Compare
gruyaume
reviewed
Dec 11, 2023
Gmerold
reviewed
Dec 12, 2023
Gmerold
requested changes
Dec 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR description says:
(...) If the free HugePages (allocatable minus allocated) are not enough, the charm will remain in Waiting status.
The code only checks the capacity tho. I think it would be great to have the feature implemented as described above.
gatici
approved these changes
Dec 12, 2023
dariofaccin
force-pushed
the
TELCO-914-move-to-blocked-when-hugepages-not-available
branch
from
December 13, 2023 09:27
fd53c5d
to
32492f0
Compare
Gmerold
approved these changes
Dec 13, 2023
dariofaccin
force-pushed
the
TELCO-914-move-to-blocked-when-hugepages-not-available
branch
from
December 14, 2023 08:27
3374e96
to
ad32f63
Compare
gruyaume
approved these changes
Jan 2, 2024
dariofaccin
force-pushed
the
TELCO-914-move-to-blocked-when-hugepages-not-available
branch
from
January 3, 2024 14:04
ad32f63
to
244e8be
Compare
dariofaccin
deleted the
TELCO-914-move-to-blocked-when-hugepages-not-available
branch
January 3, 2024 14:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds two validations to the UPF charm when enabling HugePages: the first is the support of the required CPU flags (
pdpe1gb
); the second is the capacity of enough HugePages (2Gi) on the K8S nodes. If the free HugePages (allocatable minus allocated) are not enough, the charm will remain in Waiting status.Checklist: