Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

efi/preinstall: Add missing test for expected CheckResultFlags #372

Conversation

chrisccoulson
Copy link
Collaborator

@chrisccoulson chrisccoulson commented Jan 29, 2025

The unit tests were supplying expected flags but the tests were not
actually testing that the returned value matches.

The unit tests were supplying expected flags but the tests were not
actually testing that the returned value matches.
@chrisccoulson chrisccoulson force-pushed the preinstall-add-missing-flags-check branch from 4077daf to faf99d6 Compare January 29, 2025 00:26
Copy link
Collaborator

@pedronis pedronis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, thank you

@chrisccoulson chrisccoulson merged commit 1b1f017 into canonical:master Jan 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants