-
Notifications
You must be signed in to change notification settings - Fork 445
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: add a spread test for the npm reentrant bug
The bug is caused by the plugin having state that implicitly needs to be passed from the 'pull' step to the 'build' step. If both are done in a single Snapcraft 'run', then it works fine; however, running first 'pull' and then 'build' separately trigger the issue - a failure on the build step. Ref: canonical/craft-parts#844
- Loading branch information
Showing
5 changed files
with
47 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
#!/usr/bin/env node | ||
|
||
console.log('hello world'); |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
{ | ||
"name": "npm-hello", | ||
"version": "1.0.0", | ||
"description": "Testing grounds for snapcraft integration tests", | ||
"bin": { | ||
"npm-hello": "hello.js" | ||
}, | ||
"scripts": { | ||
"npm-hello": "echo \"Error: no test specified\" && exit 1" | ||
}, | ||
"author": "", | ||
"license": "GPL-3.0" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
name: npm-reentrant | ||
version: "1.0" | ||
summary: test the npm plugin | ||
description: Check that the npm plugin works across snapcraft calls | ||
|
||
confinement: strict | ||
grade: devel | ||
base: core24 | ||
|
||
parts: | ||
hello: | ||
source: . | ||
plugin: npm | ||
npm-include-node: true | ||
npm-node-version: 22.1.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
summary: Pull, then Build, a Node snap | ||
|
||
execute: | | ||
snapcraft pull | ||
snapcraft build | ||
snapcraft pack | ||
test -f npm-reentrant*.snap | ||
restore: | | ||
snapcraft clean | ||
rm -f ./*.snap |