-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugins: kernel: split kernel plugin into kernel and initrd plugins #4302
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4302 +/- ##
==========================================
- Coverage 89.18% 89.16% -0.02%
==========================================
Files 321 324 +3
Lines 21777 21767 -10
==========================================
- Hits 19421 19408 -13
- Misses 2356 2359 +3 ☔ View full report in Codecov by Sentry. |
eba7617
to
a582799
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ondra, this is fantastic, thanks for this.
I'll circle back to the kernel, foundations and core folks to get this reviewed as well
a582799
to
a5a92f8
Compare
a5a92f8
to
5e32ec2
Compare
05f8b40
to
31c82ab
Compare
31c82ab
to
dc6c0b5
Compare
41b67a2
to
5e5ab98
Compare
27af9d2
to
d5cb90c
Compare
d5cb90c
to
394cb31
Compare
bac7288
to
aa5485c
Compare
c991f22
to
b907501
Compare
ddea88b
to
ec57c43
Compare
e77dee9
to
493cf28
Compare
kernel plugin builds two components, kernel and initrd While initrd is dependent on the kernel, it is a separate component. Separating those 2 steps into 2 own plugins will allow greater reuse of the kernel plugin as well as each plugin being owned by respective teams. Initrd steps will always depend on the kernel step, but with the plugin separation, prebuilt kernel binaries can be used with the initrd plugin In the future inird might even become the official way to build kernel snap from kernel deb packages. Signed-off-by: Ondrej Kubik <[email protected]>
Signed-off-by: Ondrej Kubik <[email protected]>
Signed-off-by: Ondrej Kubik <[email protected]>
Generic build-environment part option can be used instead. Signed-off-by: Ondrej Kubik <[email protected]>
Signed-off-by: Ondrej Kubik <[email protected]>
Signed-off-by: Ondrej Kubik <[email protected]>
Signed-off-by: Ondrej Kubik <[email protected]>
Signed-off-by: Ondrej Kubik <[email protected]>
Signed-off-by: Ondrej Kubik <[email protected]>
…ined in ubuntu-core-initrd package Signed-off-by: Ondrej Kubik <[email protected]>
Signed-off-by: Ondrej Kubik <[email protected]>
Signed-off-by: Ondrej Kubik <[email protected]>
Signed-off-by: Ondrej Kubik <[email protected]>
Signed-off-by: Ondrej Kubik <[email protected]>
Signed-off-by: Ondrej Kubik <[email protected]>
Signed-off-by: Ondrej Kubik <[email protected]>
Signed-off-by: Ondrej Kubik <[email protected]>
Signed-off-by: Ondrej Kubik <[email protected]>
Signed-off-by: Ondrej Kubik <[email protected]>
Signed-off-by: Ondrej Kubik <[email protected]>
493cf28
to
507488a
Compare
kernel plugin builds two components, kernel and initrd
While initrd is dependent on the kernel, it is a separate component.
Separating those 2 steps into 2 own plugins will allow greater reuse of the
kernel plugin as well as each plugin being owned by respective teams.
Initrd steps will always depend on the kernel step, but with
the plugin separation, prebuilt kernel binaries can be used with the initrd plugin
In the future inird might even become the official way to build kernel snap
from kernel deb packages.
For simplicity now ignoring signed kernels...