Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] ci: add reviewers workflow #4851

Closed
wants to merge 1 commit into from
Closed

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Jun 11, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

still under development

Adds the following logic:

  • When starcraft-reviewers is added to a pull request, add the needs-starcraft-review label
  • When a review is submitted, re-add the starcraft-reviewers team if the PR has needs-starcraft-review and has less than 2 reviews

This may not work if someone outside the starcraft-reviewers team approves the PR. In this case, someone would have to manually re-request starcraft-reviewers again.

@mr-cal mr-cal requested review from a team and removed request for a team June 11, 2024 22:36
@mr-cal mr-cal requested a review from a team June 11, 2024 22:38
@mr-cal mr-cal requested review from a team and removed request for a team June 11, 2024 22:43
@mr-cal mr-cal requested review from a team and removed request for a team June 11, 2024 22:51
@mr-cal mr-cal requested review from a team and removed request for a team June 11, 2024 22:56
@mr-cal mr-cal requested review from a team and removed request for a team June 11, 2024 22:56
@mr-cal mr-cal requested review from a team and removed request for a team June 11, 2024 23:01
@mr-cal mr-cal requested review from a team and removed request for a team June 11, 2024 23:02
Signed-off-by: Callahan Kovacs <[email protected]>
@mr-cal mr-cal requested review from a team and removed request for a team June 11, 2024 23:03
Copy link
Collaborator Author

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

@mr-cal mr-cal removed the request for review from a team June 12, 2024 12:34
@mr-cal mr-cal marked this pull request as draft June 12, 2024 12:34
@mr-cal mr-cal changed the title ci: add reviewers workflow [DRAFT] ci: add reviewers workflow Jun 12, 2024
@mr-cal
Copy link
Collaborator Author

mr-cal commented Jul 19, 2024

Fun experiment but too much hackery to workaround this github limitation: https://github.com/orgs/community/discussions/5289

@mr-cal mr-cal closed this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant