fix: override _run_inner instead of run to catch exceptions #5035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiusens
force-pushed
the
CRAFT-3139/run_inner
branch
2 times, most recently
from
7891cae
to
43a835f
Compare
|
core24 spread failures should disappear when you retarget hotfix/8.4. |
- Setup the emitter fixture where required - Make more use of pytest.mark.usefixtures for unused fixtures - Remove some of the unused fixtures Signed-off-by: Sergio Schvezov <[email protected]>
Remove the heading from the original error to not give the impression it is a craft application error to the user, but instead an error generated store side. Signed-off-by: Sergio Schvezov <[email protected]>
sergiusens
force-pushed
the
CRAFT-3139/run_inner
branch
from
43a835f
to
1f4734f
Compare
lengau
reviewed
Sep 18, 2024
lengau
approved these changes
Sep 18, 2024
lengau
reviewed
Sep 18, 2024
mr-cal
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox run -m lint?tox run -e test-py310? (supported versions:py39,py310,py311,py312)Fixes #4930