Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use correct type for build-on and build-for in build plans #5043

Merged
merged 1 commit into from
Sep 16, 2024
Merged

fix: use correct type for build-on and build-for in build plans #5043

merged 1 commit into from
Sep 16, 2024

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Sep 16, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

@mr-cal mr-cal marked this pull request as draft September 16, 2024 17:02
@mr-cal mr-cal requested a review from a team September 16, 2024 18:14
@mr-cal mr-cal marked this pull request as ready for review September 16, 2024 18:15
dariuszd21
dariuszd21 approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@dariuszd21 dariuszd21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dariuszd21 dariuszd21 requested a review from a team September 16, 2024 18:42
@mr-cal
Copy link
Collaborator Author

mr-cal commented Sep 16, 2024

Core20 spread test failure is an unrelated network error

@mr-cal mr-cal merged commit 19699c1 into hotfix/8.4 Sep 16, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattculler mattculler mattculler approved these changes

@dariuszd21 dariuszd21 dariuszd21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mr-cal @dariuszd21 @mattculler