kvm-test: add option to add extra disks for install #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patch introduces a new option --extra-disk-size to create additional disks in kvm-test. The option can be specified multiple times and will not affect the first disk (the one boots in presence of the --boot option). $ kvm-test.py --install --extra-disk-size 10G ... will create the first disk normally and will add an extra 10GiB disk $ kvm-test.py --extra-disk-size 10G --extra-disk-size 20G ... will create the first disk normally and will two extra disks (one of 10 and one of 20 GiB). The size of the first disk (that can be honor the --boot option) can still be configured using the --disksize option). Signed-off-by: Olivier Gayot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to reproduce https://bugs.launchpad.net/subiquity/+bug/2000066 in a VM where the original test case involves multiple disks. Sadly, I didn't manage to reproduce the crash but I think having the option in kvm-test to add extra disks would be good for future testing.
The patch introduces a new option
--extra-disk-sizeto create additional disks in kvm-test. The option can be specified multiple times and will not affect the first disk (the one boots in presence of the--bootoption).# will create the first disk normally and will add an extra 10GiB disk kvm-test.py --install --extra-disk-size 10G# will create the first disk normally and will two extra disks (one of 10 and one of 20 GiB). kvm-test.py --extra-disk-size 10G --extra-disk-size 20GThe size of the first disk (that can honor the --boot option) can still be configured using the
--disksizeoption).