filesystem: revamp udev handling #1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbungert
commented
Sep 25, 2023
dbungert
force-pushed
the
lp-2009141-udev-events
branch
3 times, most recently
from
858fecb
to
67d7625
Compare
ogayot
reviewed
Sep 27, 2023
There was a problem hiding this comment.
I think this is going in the right direction, but I would appreciate some comments to explain what is being done, including:
- the fact that the initial call to
start_monitoris done after the initial probing operation finishes (which is triggered byFilesystemController._start. - the reason why we call
stop_monitorin_udev_event. A link to the bug report maybe ?
dbungert
force-pushed
the
lp-2009141-udev-events
branch
5 times, most recently
from
c5a5713
to
a3d45f0
Compare
In LP: #2009141, we are hitting kernel limits and pyudev buffer limits. We don't care about specific events, so much as getting one event, waiting for things to calm down, then reprobing. Outright disable the event monitor, and re-enable later. If there is a storm of events, testing has shown that stopping the listener is not enough.
dbungert
force-pushed
the
lp-2009141-udev-events
branch
from
a3d45f0
to
b11726d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In LP: #2009141, we are hitting kernel limits and pyudev buffer limits.
We don't care about specific events, so much as getting one event,
waiting for things to calm down, then reprobing.
Outright disable the event monitor, and re-enable later. If there is a
storm of events, testing has shown that stopping the listener is not
enough.