Accept a fixed partition size for reset partition in autoinstall.yaml #1880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medicalwei
force-pushed
the
fixed-reset-partition-size
branch
2 times, most recently
from
3a7c13d
to
c88b41a
Compare
|
There's some underlying serialization issues since attempting to union primitives upsets serialize.py as it seems only taking unions of non-primitive types. Is this intentional? EDIT: new overridden commits fixed the issue. |
medicalwei
force-pushed
the
fixed-reset-partition-size
branch
3 times, most recently
from
3789b31
to
8edbf6d
Compare
ogayot
approved these changes
Jan 24, 2024
medicalwei
force-pushed
the
fixed-reset-partition-size
branch
from
8edbf6d
to
58bfe12
Compare
dbungert
reviewed
Feb 8, 2024
There was a problem hiding this comment.
I would like to see some doc/reference/autoinstall-reference.rst material for this, but then I see now that reset-partition isn't documented yet. Unfortunate. @medicalwei would you add some content for this in the reference and ignore the bit where the reset_partition bool isn't documented yet?
medicalwei
force-pushed
the
fixed-reset-partition-size
branch
from
3a416c8
to
61d748d
Compare
|
@dbungert Reference added, and I hope my writing style doesn't look strange |
dbungert
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset will allow reset_partition to accept int or human-readable disk size (e.g. "12G"), so that the size of reset partition can be fixed. This will be used for some OEM deployments and automated testing where overwriting or updating reset partition is necessary.