Simplify systemd configuration for console-conf #2071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having `[email protected]` and `[email protected]` starting each others seem to generate errors on shut down. ``` [ 115.522870] systemctl[1011]: Got message type=error sender=org.freedesktop.systemd1 destination=n/a path=n/a interface=n/a member=n/a cookie=1 reply_cookie=1 signature=s error-name=org.freedesktop.systemd1.TransactionIsDestructive error-message=Transaction for [email protected]/star [ 115.524325] systemctl[1011]: t is destructive (systemd-poweroff.service has 'start' job queued, but 'stop' is included in transaction). [ 115.525067] systemctl[1011]: Failed to start [email protected]: Transaction for [email protected]/start is destructive (systemd-poweroff.service has 'start' job queued, but 'stop' is included in transaction). ``` Instead we should just have both `console-conf@` and `getty@` enabled and select with conditions. Serial port services are enabled by a generator, in a similar way as `systemd-getty-generator` for `serial-getty@`.
dbungert
approved these changes
Aug 29, 2024
alfonsosanchezbeato
added a commit
to alfonsosanchezbeato/core-base
that referenced
this pull request
Sep 3, 2024
Update console-conf so it includes canonical/subiquity#2071.
alfonsosanchezbeato
added a commit
to canonical/core-base
that referenced
this pull request
Oct 15, 2024
Update console-conf so it includes canonical/subiquity#2071.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #1478 to core/jammy branch.
Having
[email protected]and[email protected]starting each others seem to generate errors on shut down.Instead we should just have both
console-conf@andgetty@enabled and select with conditions.Serial port services are enabled by a generator, in a similar way as
systemd-getty-generatorforserial-getty@.