Kernel crash dumps autoinstall #2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwhudson
reviewed
Sep 5, 2024
mwhudson
reviewed
Sep 5, 2024
Chris-Peterson444
force-pushed
the
kernel-crash-dumps-introduction
branch
2 times, most recently
from
d259f65
to
332282a
Compare
|
Either way really. I suppose if we wait it'd save us a slightly annoying revert if it ends up not landing in curtin. |
ogayot
reviewed
Sep 6, 2024
Chris-Peterson444
force-pushed
the
kernel-crash-dumps-introduction
branch
from
332282a
to
0c64aba
Compare
ogayot
approved these changes
Sep 6, 2024
dbungert
reviewed
Sep 9, 2024
| .. code-block:: yaml | ||
|
|
||
| autoinstall: | ||
| # Allow kernel crash dumps to be enabled dynamically. |
There was a problem hiding this comment.
only 24.10 sees this default behavior, pre-24.10 is default off, let's spell that out.
There was a problem hiding this comment.
Good point. Done!
Chris-Peterson444
force-pushed
the
kernel-crash-dumps-introduction
branch
2 times, most recently
from
452315e
to
6e572d6
Compare
dbungert
approved these changes
Sep 9, 2024
Introduce the KernelCrashDumpsController and KernelCrashDumpsModel, a
non-interactive controller-model pair for setting the kernel-crash-dumps
curthooks config. Practically, we introduce a new autoinstall section
with the same format as the relevant curthooks config to selectively
enable or disable kernel crash dumps on the target system. The default
configuration is `{ "enabled": null }` which will let curtin perform
dynamic enablement.
The needed wiring to make subiquity use the new kernel crash dumps related controller and model.
Chris-Peterson444
force-pushed
the
kernel-crash-dumps-introduction
branch
from
6e572d6
to
646c0d9
Compare
Allow check for `None` type in check-yaml-fields.py script. It wasn't clear from the original commit - 2ddde49 - if we purposefully didn't want to compare `null` in the script, or it was just a typo. This will now let us assert a field should be `null` instead of some other value, and fail properly when it is not.
- Add an example kernel-crash-dumps section to the most-options.yaml example file and check the curthook is updated correctly. - Add a check in the autoinstall-simple case that asserts the default value for the kernel-crash-dumps curthook config.
Chris-Peterson444
force-pushed
the
kernel-crash-dumps-introduction
branch
from
646c0d9
to
be8d1b1
Compare
Done! If I'm missing anything else let me know please. Here is the MP for the relevant curtin changes: https://code.launchpad.net/~cpete/curtin/+git/curtin/+merge/473169 |
dbungert
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the
KernelCrashDumpsControllerandKernelCrashDumpsModel, a non-interactive controller-model pair for setting the kernel-crash-dumps curthooks config. Practically, we introduce a new autoinstall section with the same format as the relevant curthooks config to selectively enable or disable kernel crash dumps on the target system. The defaultconfiguration is
{ "enabled": null }which will let curtin perform dynamic enablement.Currently this is a no-op since the
kernel-crash-dumpscurthooks section hasn't been implemented in curtin yet.