Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oracular / storage: log disk-id in POST /storage/v2/add_boot_partition #2099

Merged

Conversation

ogayot
Copy link
Member

@ogayot ogayot commented Oct 8, 2024

It seems that we have a strange behavior when
/storage/v2/add_boot_partition is called on a disk different from the disk partitioned for installation. However, we did not log the disk ID so post-mortem analysis is very hard.

Signed-off-by: Olivier Gayot [email protected]
(cherry picked from commit de5356b)

CC: @d-loose

It seems that we have a strange behavior when
/storage/v2/add_boot_partition is called on a disk different from the
disk partitioned for installation. However, we did not log the disk ID
so post-mortem analysis is very hard.

Signed-off-by: Olivier Gayot <[email protected]>
(cherry picked from commit de5356b)
@ogayot ogayot changed the title storage: log disk-id in POST /storage/v2/add_boot_partition Oracular / storage: log disk-id in POST /storage/v2/add_boot_partition Oct 8, 2024
Copy link
Collaborator

@dbungert dbungert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please confirm it has seen at least one VM test.

@ogayot
Copy link
Member Author

ogayot commented Oct 8, 2024

LGTM, but please confirm it has seen at least one VM test.

That worked, as shown below.

2024-10-08 14:58:34,646 DEBUG subiquity.server.controllers.filesystem:1330 v2_add_boot_partition: disk-id: disk-vda

@ogayot ogayot merged commit 1a7a115 into canonical:ubuntu/oracular Oct 8, 2024
12 checks passed
@ogayot ogayot deleted the oracular-log-add-boot-partition branch October 8, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants