snapcraft: explicitly pull python3-more-itertools for core24 #2106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subiquity relies on the more_itertools Python module. However, python3-more-itertools was not listed as a staged package in snnapcraft.yaml. When running Subiquity on core24, this leads to a ModuleNotFoundError. For earlier core versions, python3-more-itertools was pulled as a transitive dependency so it was working ok. Signed-off-by: Olivier Gayot <[email protected]>
dbungert
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subiquity relies on the more_itertools Python module. However, python3-more-itertools was not listed as a staged package in snnapcraft.yaml.
When running Subiquity on core24, this leads to a ModuleNotFoundError. For earlier core versions, python3-more-itertools was pulled as a transitive dependency so it was working ok.