reordered imports to fix regression in otlp package cleanup #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PietroPasotti
force-pushed
the
fix/stale_otel_packages_regression
branch
3 times, most recently
from
7260e53 to
0a3de26
Compare
PietroPasotti
force-pushed
the
fix/stale_otel_packages_regression
branch
from
0a3de26 to
722972f
Compare
|
The behaviour was a bit interesting: right after the model settled, I didn't see any charm traces from tempo-coordinator-k8s. I'm wondering if this is related to workload's eventual consistency or settling. They however appeared later and the first events I'm seeing is
|
mmkay
reviewed
Feb 7, 2025
blacken scripts
Co-authored-by: Mateusz Kulewicz <[email protected]> Signed-off-by: PietroPasotti <[email protected]>
mmkay
reviewed
Feb 11, 2025
mmkay
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107
we thought we fixed this already: we added a hack to remove stale otlp packages because juju fails to clean them up properly on upgrade.
However later in #57 we added an otlp import BEFORE the patch and that broke things again.
This regression is hard to test for without running a full upgrade integration test.
Some of the packages we use for linting must have had new releases recently because I had to fix a bunch of unrelated staff to make the lint env happy.
The only non-linty changes are to the charm_tracing lib.
When fixing one of those linting errors, I found out there was an actual bug in the charm_tracing buffer, so I fixed that one too by refactoring the save/prune logic.
to test: deploy tempo, verify that the init sequence events have been buffered and then flushed.