Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coordinator to support multiple config generations #115

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

michaeldmitry
Copy link
Contributor

@michaeldmitry michaeldmitry commented Feb 20, 2025

Issue

Fixes #101
In preparation to use 2.7.1 tempo rock in Tempo-worker, we need to do some changes in the coordinator to be able to serve different configs depending on the workload version the worker is running.

Solution

  • Define a default pydantic model scheme (to work with all workers before 2.7.1) and a 2.7.1 scheme
  • Instead of generating the config blindly, pass the responsibility to a TempoConfigBuilderFactory to retrieve the correct config builder depending on the workload version sent from the workers.

Context

For backwards compatibility:

  • keep jaeger_thrift_http

Drive-bys

  • Explicitly add 0.0.0.0:port for all receivers
  • Add otlp_http as a workload tracing protocol

Testing Instructions

  • This CI passing tests for backward compatibility that the upgraded worker will still work with an outdated worker.
  • Run itests for this coordinator with this worker

@michaeldmitry michaeldmitry changed the title Update receivers listeners Update coordinator to support multiple config generations Feb 21, 2025
@michaeldmitry michaeldmitry marked this pull request as draft February 21, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update adresses Tempo listens to for 2.7.0 release
1 participant